Add ut in Subnet/SubnetSet controllers related with SubnetConnectionBindingMaps #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wenyingd
commented
Dec 13, 2024
wenyingd
commented
- Add unit test in Subnet/SubnetSet controllers related with SubnetConnectionBindingMaps
- Add unit test in SubnetConnectionBindingMaps services to verify the paging logic
wenyingd
force-pushed
the
subnetbinding_ut
branch
from
2cb4499 to
ba75f76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
==========================================
+ Coverage 73.37% 74.03% +0.65%
==========================================
Files 118 118
Lines 16394 16394
==========================================
+ Hits 12029 12137 +108
+ Misses 3581 3482 -99
+ Partials 784 775 -9
|
wenyingd
force-pushed
the
subnetbinding_ut
branch
from
ba75f76 to
93e846d
Compare
…ectionBindingMaps
wenyingd
force-pushed
the
subnetbinding_ut
branch
from
93e846d to
9312600
Compare
|
/e2e |
yanjunz97
approved these changes
Jan 2, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 3, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 3, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 3, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 3, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 6, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 6, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 6, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 6, 2025
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.